Put full version of Go in go.mod while updating#41563
Merged
rdner merged 1 commit intoelastic:mainfrom Nov 8, 2024
Merged
Conversation
The previous configuration was always replacing the full version of Go with a minor version: 1.22.8 -> 1.22. Newer versions of Go now put the full version value in `go.mod`. This leads to our CI failing because `go mod tidy` causes a change in `go.mod`. This is to fix those failures.
rdner
added
bug
Team:Elastic-Agent
Contributor
|
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
Contributor
|
Pinging @elastic/elastic-agent (Team:Elastic-Agent) |
botelastic
bot
added
needs_team
Contributor
|
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
Contributor
|
|
mergify
bot
added
the
backport-8.x
swiatekm
approved these changes
Nov 8, 2024
pierrehilbert
approved these changes
Nov 8, 2024
alexsapran
approved these changes
Nov 8, 2024
mergify bot
pushed a commit
that referenced
this pull request
Nov 8, 2024
The previous configuration was always replacing the full version of Go with a minor version: 1.22.8 -> 1.22. Newer versions of Go now put the full version value in `go.mod`. This leads to our CI failing because `go mod tidy` causes a change in `go.mod`. This is to fix those failures. (cherry picked from commit bfaa70f)
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous configuration was always replacing the full version of Go with a minor version: 1.22.8 -> 1.22.
Newer versions of Go now put the full version value in
go.mod. This leads to our CI failing becausego mod tidycauses a change ingo.mod.This is to fix those failures.